[webkit-changes] [WebKit/WebKit] fd4ac7: Support rendering non-native <progress> in vertica...
Tim Nguyen
noreply at github.com
Thu Mar 30 10:00:50 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fd4ac798e708eb677e85f3f9b847c29898eb584e
https://github.com/WebKit/WebKit/commit/fd4ac798e708eb677e85f3f9b847c29898eb584e
Author: Tim Nguyen <ntim at apple.com>
Date: 2023-03-30 (Thu, 30 Mar 2023)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/editing/style/apply-style-atomic-expected.txt
M LayoutTests/editing/style/apply-style-atomic-live-range-expected.txt
M LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt
M LayoutTests/fast/dom/HTMLProgressElement/progress-clone.html
M LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup-expected.txt
M LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup.html
M LayoutTests/fast/dom/HTMLProgressElement/progress-writing-mode-expected.html
M LayoutTests/fast/dom/HTMLProgressElement/progress-writing-mode.html
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/progress-appearance-native-computed-style.optional-expected.txt
M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/progress-appearance-native-computed-style.optional-expected.txt
M Source/WebCore/css/horizontalFormControls.css
M Source/WebCore/css/html.css
M Source/WebCore/html/HTMLProgressElement.cpp
M Source/WebCore/html/shadow/ProgressShadowElement.cpp
M Source/WebCore/html/shadow/ProgressShadowElement.h
Log Message:
-----------
Support rendering non-native <progress> in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=247754
rdar://102477867
Reviewed by Aditya Keerthi.
Update relevant rules to use logical properties.
Enable <progress> in vertical writing mode behind the VerticalFormControlsEnabled setting.
Native <progress> appearance will also need to be painted vertically, but that will be done in a separate commit.
* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/progress-appearance-native-computed-style.optional-expected.txt:
* LayoutTests/editing/style/apply-style-atomic-expected.txt:
* LayoutTests/editing/style/apply-style-atomic-live-range-expected.txt:
* LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt:
* LayoutTests/fast/dom/HTMLProgressElement/progress-clone.html:
* LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:
* LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup.html:
* LayoutTests/fast/dom/HTMLProgressElement/progress-writing-mode-expected.html:
* LayoutTests/fast/dom/HTMLProgressElement/progress-writing-mode.html:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/progress-appearance-native-computed-style.optional-expected.txt:
* Source/WebCore/css/horizontalFormControls.css:
(@namespace "http://www.w3.org/1999/xhtml";):
* Source/WebCore/css/html.css:
(select, button, meter, input:is([type="button"], [type="submit"], [type="reset"], [type="file"])):
(progress):
(progress::-webkit-progress-value):
(select, button, meter, progress, input:is([type="button"], [type="submit"], [type="reset"], [type="file"])): Deleted.
* Source/WebCore/html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::didAddUserAgentShadowRoot):
* Source/WebCore/html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressValueElement::setInlineSizePercentage):
(WebCore::ProgressValueElement::setWidthPercentage): Deleted.
* Source/WebCore/html/shadow/ProgressShadowElement.h:
Canonical link: https://commits.webkit.org/262336@main
More information about the webkit-changes
mailing list