[webkit-changes] [WebKit/WebKit] 700f65: WasmBBQJIT performs redundant overflow check when ...

Commit Queue noreply at github.com
Thu Mar 30 09:54:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 700f6525d4cf86039f4771389dddbe111e0b15a1
      https://github.com/WebKit/WebKit/commit/700f6525d4cf86039f4771389dddbe111e0b15a1
  Author: David Degazio <d_degazio at apple.com>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    A JSTests/wasm/stress/foldable-division.js
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  WasmBBQJIT performs redundant overflow check when dividend is constant
https://bugs.webkit.org/show_bug.cgi?id=254710
rdar://106823148

Reviewed by Yusuke Suzuki.

Always skip the integer division overflow check (specifically for the case INT_MIN / -1)
in WasmBBQJIT when the left operand is a constant. This reduces the amount of unnecessary
work checking for erroneous divisions, and also allows the general case to assume neither
operand is a constant when emitting the check.

* JSTests/wasm/stress/foldable-division.js: Added.
(async test):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::emitModOrDiv):

Canonical link: https://commits.webkit.org/262335@main




More information about the webkit-changes mailing list