[webkit-changes] [WebKit/WebKit] 059e2b: RenderLayer::hasVisibleContent() incorrect when la...

Ahmad Saleem noreply at github.com
Wed Mar 29 12:34:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 059e2bb75dc33571362fae9152d36631b1df91ba
      https://github.com/WebKit/WebKit/commit/059e2bb75dc33571362fae9152d36631b1df91ba
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    A LayoutTests/compositing/visibility/visibility-remove-layer-expected.html
    A LayoutTests/compositing/visibility/visibility-remove-layer.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  RenderLayer::hasVisibleContent() incorrect when layer removed

https://bugs.webkit.org/show_bug.cgi?id=253706
rdar://problem/106860749

Reviewed by Simon Fraser.

This patch is to align WebKit with Blink / Chromium and Gecko / Firefox.

Merge - https://chromium.googlesource.com/chromium/blink/+/c5587982b1ed1ec62452f5d2c93c0f385a3941a1

Prior to this change, we were incorrectly dirtying
RenderLayer::hasVisibleContent() when removing a RenderLayer from the layer
tree. This caused us to incorrectly believe that the parent layer lacked
visible content.

* Source/WebCore/rendering/RenderLayer.cpp:
(RenderLayer::removeChild):
* LayoutTests/compositing/visibility/visibility-remove-layer.html: Add Test Case
* LayoutTests/compositing/visibility/visibility-remove-layer-expected.html: Add Test Case

Canonical link: https://commits.webkit.org/262284@main




More information about the webkit-changes mailing list