[webkit-changes] [WebKit/WebKit] afc536: [popover] event.preventDefault() should not cancel...
Rob Buis
noreply at github.com
Wed Mar 29 11:52:20 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: afc536e4bc276f974e802f28e5440b316ce2736f
https://github.com/WebKit/WebKit/commit/afc536e4bc276f974e802f28e5440b316ce2736f
Author: Rob Buis <rbuis at igalia.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/light-dismiss-event-ordering-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/Node.cpp
M Source/WebCore/page/PointerCaptureController.cpp
Log Message:
-----------
[popover] event.preventDefault() should not cancel popover light dismiss
https://bugs.webkit.org/show_bug.cgi?id=254384
Reviewed by Tim Nguyen.
Move light dismiss logic to PointerCaptureController::dispatchEvent so the event can't
be cancelled, also see:
https://github.com/whatwg/dom/pull/1117#issuecomment-1311928234
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/light-dismiss-event-ordering-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::handlePopoverLightDismiss):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
* Source/WebCore/page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::pointerEventWillBeDispatched):
Canonical link: https://commits.webkit.org/262283@main
More information about the webkit-changes
mailing list