[webkit-changes] [WebKit/WebKit] ea7b75: RenderBox::computeInlineDirectionMargins() is caus...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea7b758f5d2efc5c1b6a00f46fe51c5b6e7c1560
      https://github.com/WebKit/WebKit/commit/ea7b758f5d2efc5c1b6a00f46fe51c5b6e7c1560
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h

  Log Message:
  -----------
  RenderBox::computeInlineDirectionMargins() is causing system malloc heap allocations
https://bugs.webkit.org/show_bug.cgi?id=254646

Reviewed by Darin Adler.

RenderBox::computeInlineDirectionMargins() was causing system malloc heap
allocations due to its use of std::function:

Sample Count, Samples %, Normalized CPU %, Symbol
21, 0.0%, 0.0%, tiny_malloc_should_clear (in libsystem_malloc.dylib)
20, 0.0%, 0.0%,     szone_malloc_should_clear (in libsystem_malloc.dylib)
8, 0.0%, 0.0%,         operator new(unsigned long) (in libc++abi.dylib)
5, 0.0%, 0.0%,             WebCore::RenderBox::computeInlineDirectionMargins(WebCore::RenderBlock const&, WebCore::LayoutUnit, std::__1::optional<WebCore::LayoutUnit>, WebCore::LayoutUnit, WebCore::LayoutUnit&, WebCore::LayoutUnit&) const (in WebCore)
3, 0.0%, 0.0%,             WebCore::RenderBox::fillAvailableMeasure(WebCore::LayoutUnit, WebCore::LayoutUnit&, WebCore::LayoutUnit&) const (in WebCore)

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::fillAvailableMeasure const):
(WebCore::RenderBox::computeOrTrimInlineMargin const):
(WebCore::RenderBox::computeInlineDirectionMargins const):
* Source/WebCore/rendering/RenderBox.h:

Canonical link: https://commits.webkit.org/262274@main