[webkit-changes] [WebKit/WebKit] 1490a5: [JSC] Fix Win crash in Temporal since/until methods

Ross Kirsling noreply at github.com
Wed Mar 29 07:48:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1490a5c2a806d767de0b4e2dd113a35053467eea
      https://github.com/WebKit/WebKit/commit/1490a5c2a806d767de0b4e2dd113a35053467eea
  Author: Ross Kirsling <rkirsling at gmail.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/runtime/TemporalObject.cpp

  Log Message:
  -----------
  [JSC] Fix Win crash in Temporal since/until methods
https://bugs.webkit.org/show_bug.cgi?id=254650

Reviewed by Mark Lam.

Without a JSC testbot for Windows, we hadn't noticed that Temporal.{PlainDate, PlainTime}#{since, until} can crash.

The crux of the issue seems to be in having a static constexpr std::initializer_list array,
but this can just be a static local anyway.

* Source/JavaScriptCore/runtime/TemporalObject.cpp:
(JSC::extractDifferenceOptions):

Canonical link: https://commits.webkit.org/262273@main




More information about the webkit-changes mailing list