[webkit-changes] [WebKit/WebKit] f20573: Bug 254443 - AX: Only FRED VP visible on the Text ...

Chris Fleizach noreply at github.com
Sat Mar 25 15:20:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f20573ec09c611d9bbb4f6327ca9f37c7ee3d16a
      https://github.com/WebKit/WebKit/commit/f20573ec09c611d9bbb4f6327ca9f37c7ee3d16a
  Author: Chris Fleizach <cfleizach at apple.com>
  Date:   2023-03-25 (Sat, 25 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/speechsynthesis/mac/samantha-voice-available-expected.txt
    A LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/PAL/pal/spi/cocoa/AXSpeechManagerSPI.h
    M Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm

  Log Message:
  -----------
  Bug 254443 - AX: Only FRED VP visible on the Text To Speech Sound Check page
https://bugs.webkit.org/show_bug.cgi?id=254443
rdar://107199586

Reviewed by Tyler Wilcock.

On some platforms, a compact voice will be upgraded to a better one. When that happens, the older
compact voices are not returned to API. This is a problem for WebKit which can only use these compact voices.

Use a new SPI to retrieve the right set of voices.

* LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html: Added.
* LayoutTests/fast/speechsynthesis/mac/samantha-voice-available-expected.txt: Added.
* Source/WebCore/PAL/pal/spi/cocoa/AXSpeechManagerSPI.h:
* Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm:
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

Canonical link: https://commits.webkit.org/262117@main




More information about the webkit-changes mailing list