[webkit-changes] [WebKit/WebKit] ba2835: Cherry-pick 262106 at main (ed99b93877dd). https://bu...

[Antoine Quint]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: ba2835a6f2f8484a7cefbb6abc3e69c18e2aaff5
      https://github.com/WebKit/WebKit/commit/ba2835a6f2f8484a7cefbb6abc3e69c18e2aaff5
  Author: Patrick Angle <pangle at apple.com>
  Date:   2023-03-25 (Sat, 25 Mar 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
    M Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js
    M Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js
    M Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
    M Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js
    M Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
    M Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js
    M Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js
    M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
    M Source/WebInspectorUI/UserInterface/Views/WebSocketResourceTreeElement.js

  Log Message:
  -----------
  Cherry-pick 262106 at main (ed99b93877dd). https://bugs.webkit.org/show_bug.cgi?id=253273

    Web Inspector: (Regression: 254636 at main) Mini console always opens when choosing "Inspect Element", even if it was previously closed
    https://bugs.webkit.org/show_bug.cgi?id=253273
    rdar://106260652

    Reviewed by Devin Rousso.

    When console snippets were introduced, the function signature of `appendImmediateExecutionWithResult` was updated so
    that optional values were part of an options object. However, in changing that it appears it was assumed that the
    default would be flipped to `false`, but that never happened. The parameter was no longer being provided by DOMManger
    when inspecting an element, and therefor we fell back to the default of showing the quick console.

    To fix this, we correct the `shouldRevealConsole` to be `false` by default, matching other option objects, and then
    clean up other places where we were assuming it would still be true (mostly anywhere that a "Log [thing]" option was
    present).

    * Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
    (WI.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
    (WI.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
    - Use the new options object of the ConsoleCommandResultMessage constructor.

    * Source/WebInspectorUI/UserInterface/Models/ConsoleCommandResultMessage.js:
    - Make `shouldRevealConsole` part of an options object, and make it default to false instead.

    * Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:
    (WI.AnimationContentView.prototype._populateAnimationTargetButtonContextMenu):
    (WI.AnimationContentView):
    * Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js:
    (WI.CanvasContentView.prototype._populateCanvasElementButtonContextMenu):
    * Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:
    (WI.CanvasTreeElement.prototype.populateContextMenu):
    * Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:
    * Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js:
    (WI.ObjectPreviewView.prototype._contextMenuHandler):
    (WI.ObjectPreviewView):
    * Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js:
    (WI.ObjectTreeBaseTreeElement.prototype._logSymbolProperty):
    (WI.ObjectTreeBaseTreeElement.prototype._logValue):
    * Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:
    (WI.QuickConsole.prototype._handleDrop):
    * Source/WebInspectorUI/UserInterface/Views/WebSocketResourceTreeElement.js:
    (WI.WebSocketResourceTreeElement.prototype.populateContextMenu):

    Canonical link: https://commits.webkit.org/262106@main


  Commit: a55c5f966312cbdfbeebfe0fc14d6a1dbe3a437d
      https://github.com/WebKit/WebKit/commit/a55c5f966312cbdfbeebfe0fc14d6a1dbe3a437d
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-03-25 (Sat, 25 Mar 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed.html
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  -----------
  Cherry-pick 262076 at main (46d858959377). https://bugs.webkit.org/show_bug.cgi?id=254401

    Animations inside a Details tag only fire once
    https://bugs.webkit.org/show_bug.cgi?id=254401

    Reviewed by Antti Koivisto.

    We should always cancel declarative animations in case of a Full teardown, and never
    in the FullAfterSlotChange case. We remove the FALLTHROUGH to make this all clearer
    and better distinguish the Full and FullAfterSlotChange cases.

    * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed-expected.txt: Added.
    * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed.html: Added.
    * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
    (WebCore::RenderTreeUpdater::tearDownRenderers):

    Canonical link: https://commits.webkit.org/262076@main


  Commit: 117ae8038567ae13292219c6926b2e7136785618
      https://github.com/WebKit/WebKit/commit/117ae8038567ae13292219c6926b2e7136785618
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-03-25 (Sat, 25 Mar 2023)

  Changed paths:
    M LayoutTests/platform/gtk/TestExpectations
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp

  Log Message:
  -----------
  Cherry-pick 262075 at main (9a3c1c8a3991). https://bugs.webkit.org/show_bug.cgi?id=254408

    [GTK] Allow pasting content with async clipboard when origin is the same
    https://bugs.webkit.org/show_bug.cgi?id=254408

    Reviewed by Michael Catanzaro.

    * LayoutTests/platform/gtk/TestExpectations:
    * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
    * Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
    (WebKit::PageClientImpl::requestDOMPasteAccess):

    Canonical link: https://commits.webkit.org/262075@main


  Commit: 7629cf06b588543cee60354320fcc98f20843778
      https://github.com/WebKit/WebKit/commit/7629cf06b588543cee60354320fcc98f20843778
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-03-26 (Sun, 26 Mar 2023)

  Changed paths:
    A LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow-expected.txt
    A LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow.html
    M Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js

  Log Message:
  -----------
  Cherry-pick 261912 at main (2972c6591e21). https://bugs.webkit.org/show_bug.cgi?id=254165

    [media controls] overflow button appears clipped on Google Research page
    https://bugs.webkit.org/show_bug.cgi?id=254165
    rdar://104744690

    Reviewed by Devin Rousso.

    We must account for _visible_ children when determining whether the right bar container should be shown.

    * LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow-expected.txt: Added.
    * LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow.html: Added.
    * Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js:
    (InlineMediaControls.prototype.layout):

    Canonical link: https://commits.webkit.org/261912@main


Compare: https://github.com/WebKit/WebKit/compare/d516adb9242e...7629cf06b588