[webkit-changes] [WebKit/WebKit] 2c9b83: RenderBlockFlows with no children should not even ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c9b8339e50271164d25924f3480325ac745840d
      https://github.com/WebKit/WebKit/commit/2c9b8339e50271164d25924f3480325ac745840d
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  RenderBlockFlows with no children should not even try to run inline layout
https://bugs.webkit.org/show_bug.cgi?id=254391

Reviewed by Antti Koivisto.

1. RenderBlockFlow's initial state is m_childrenInline = true
2. m_childrenInline is set to true when the block ends up with no children.
3. childrenInline() makes RenderBlockFlow run inline layout.

Initiating layout (IFC or BFC) does not make much sense when there's nothing to run layout on.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren): RenderSVGText calls layoutInlineChildren with no children :|

Canonical link: https://commits.webkit.org/262077@main