[webkit-changes] [WebKit/WebKit] 46d858: Animations inside a Details tag only fire once

Antoine Quint noreply at github.com
Fri Mar 24 08:58:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46d8589593777d7e9f8f23c66beabb1217205ba7
      https://github.com/WebKit/WebKit/commit/46d8589593777d7e9f8f23c66beabb1217205ba7
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed.html
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  -----------
  Animations inside a Details tag only fire once
https://bugs.webkit.org/show_bug.cgi?id=254401

Reviewed by Antti Koivisto.

We should always cancel declarative animations in case of a Full teardown, and never
in the FullAfterSlotChange case. We remove the FALLTHROUGH to make this all clearer
and better distinguish the Full and FullAfterSlotChange cases.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-canceled-by-parent-details-element-being-closed.html: Added.
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):

Canonical link: https://commits.webkit.org/262076@main




More information about the webkit-changes mailing list