[webkit-changes] [WebKit/WebKit] 4ca89d: OffscreenCanvas does not work as TexImageSource in...

Kimmo Kinnunen noreply at github.com
Thu Mar 23 01:22:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ca89ddeb5a2a28a9cfdb1e3bdd2891c79930b51
      https://github.com/WebKit/WebKit/commit/4ca89ddeb5a2a28a9cfdb1e3bdd2891c79930b51
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/canvas/WebGL2RenderingContext.h
    M Source/WebCore/html/canvas/WebGL2RenderingContext.idl
    M Source/WebCore/html/canvas/WebGLRenderingContext.idl
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h

  Log Message:
  -----------
  OffscreenCanvas does not work as TexImageSource in WebGL
https://bugs.webkit.org/show_bug.cgi?id=253886
rdar://106700463

Reviewed by Matt Woodrow.

Add texImageSource overload for OffscreenCanvas. Later on the Context2D,
WebGL and OffscreenCanvas codepaths could be unified and made faster.

* Source/WebCore/html/canvas/WebGL2RenderingContext.h:
* Source/WebCore/html/canvas/WebGL2RenderingContext.idl:
* Source/WebCore/html/canvas/WebGLRenderingContext.idl:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImageSource):
(WebCore::WebGLRenderingContextBase::validateOffscreenCanvas):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
* LayoutTests/TestExpectations:
Explicitly add pass on tests that would timeout with OffscreenCanvas
not working correctly.

Canonical link: https://commits.webkit.org/262009@main




More information about the webkit-changes mailing list