[webkit-changes] [WebKit/WebKit] 3e3695: [web-animations] Make WPT test at animation-model/...

Antoine Quint noreply at github.com
Thu Mar 23 00:51:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e3695777894f55445055f997000fb74fc9e92ae
      https://github.com/WebKit/WebKit/commit/3e3695777894f55445055f997000fb74fc9e92ae
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance-expected.txt
    M LayoutTests/transitions/frames-timing-function-expected.txt
    M Source/WebCore/platform/graphics/UnitBezier.h

  Log Message:
  -----------
  [web-animations] Make WPT test at animation-model/keyframe-effects/effect-value-transformed-distance.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=186493
<rdar://problem/41000157>

Reviewed by Dean Jackson.

Unsure as to why we were the only browser to fail this test related to cubic-bezier accuracy,
I adjusted our UnitBezier code to match Chromium's ui/gfx/geometry/cubic_bezier.cc and this
solved this browser-specific failure.

This also addressed the issue where css/css-easing/cubic-bezier-timing-functions-output.html
was a unique failure in WebKit.

* LayoutTests/imported/w3c/web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance-expected.txt:
* LayoutTests/transitions/frames-timing-function-expected.txt:
* Source/WebCore/platform/graphics/UnitBezier.h:
(WebCore::UnitBezier::UnitBezier):
(WebCore::UnitBezier::solveCurveX):
(WebCore::UnitBezier::solve):

Canonical link: https://commits.webkit.org/262008@main




More information about the webkit-changes mailing list