[webkit-changes] [WebKit/WebKit] 13c816: DocumentTimeline doesn't need to unregister itself...

Chris Dumez noreply at github.com
Wed Mar 22 21:11:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13c816f5c7b2fb47bda7f1b3b22b863194d73f8d
      https://github.com/WebKit/WebKit/commit/13c816f5c7b2fb47bda7f1b3b22b863194d73f8d
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M Source/WebCore/animation/AnimationTimeline.h
    M Source/WebCore/animation/DocumentTimeline.cpp
    M Source/WebCore/animation/DocumentTimeline.h
    M Source/WebCore/animation/DocumentTimelinesController.cpp

  Log Message:
  -----------
  DocumentTimeline doesn't need to unregister itself from DocumentTimelinesController
https://bugs.webkit.org/show_bug.cgi?id=254296

Reviewed by Ryosuke Niwa.

DocumentTimeline doesn't need to unregister itself from DocumentTimelinesController
on destruction since the DocumentTimelinesController is using a WeakHashSet.

* Source/WebCore/animation/AnimationTimeline.h:
* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::~DocumentTimeline): Deleted.
* Source/WebCore/animation/DocumentTimeline.h:
* Source/WebCore/animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):

Canonical link: https://commits.webkit.org/262002@main




More information about the webkit-changes mailing list