[webkit-changes] [WebKit/WebKit] 313f87: Assertion failure in compositeeditcommand::movePar...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 313f87a7b574c37c446b5accddf65ba3f7fa1f3c
      https://github.com/WebKit/WebKit/commit/313f87a7b574c37c446b5accddf65ba3f7fa1f3c
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    A LayoutTests/editing/execCommand/insert-ordered-list-move-paragraph-removes-destination-expected.txt
    A LayoutTests/editing/execCommand/insert-ordered-list-move-paragraph-removes-destination.html
    M Source/WebCore/editing/CompositeEditCommand.cpp

  Log Message:
  -----------
  Assertion failure in compositeeditcommand::moveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=254302

Reviewed by Wenson Hsieh.

The assertion failure was caused by deleteSelection removing the destination node. This occurred because
we were adjusting destination to be within the content (i.e. text node before br element) to be deleted
when canonicalizing to visible position. Remember the downstream position in the case this happens and
re-create VisiblePosition out of this downstream position if deleteSelection orphaned the destination.

* LayoutTests/editing/execCommand/insert-ordered-list-move-paragraph-removes-destination-expected.txt: Added.
* LayoutTests/editing/execCommand/insert-ordered-list-move-paragraph-removes-destination.html: Added.
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):

Canonical link: https://commits.webkit.org/262001@main