[webkit-changes] [WebKit/WebKit] ed1422: Improve display of wide-layout attachment on iOS

Gerald Squelart noreply at github.com
Mon Mar 20 18:49:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed1422596dce5ff012e64a38faf402ac1674fc7e
      https://github.com/WebKit/WebKit/commit/ed1422596dce5ff012e64a38faf402ac1674fc7e
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/shadow/attachmentElementShadow.css
    M Source/WebCore/rendering/AttachmentLayout.mm
    M Source/WebCore/rendering/RenderThemeIOS.mm

  Log Message:
  -----------
  Improve display of wide-layout attachment on iOS
https://bugs.webkit.org/show_bug.cgi?id=254142
rdar://problem/106925105

Reviewed by Aditya Keerthi.

Progress towards the target specs, in particular the colors and icon display.

* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
(WebCore::HTMLAttachmentElement::updateThumbnail):
(WebCore::HTMLAttachmentElement::updateIcon):
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-container):
(div#attachment-container::selection):
(div#attachment-preview-area):
(attachment#attachment-preview):
(div#attachment-information-area):
(div#attachment-information-block):
(div#attachment-action):
(div#attachment-title):
(div#attachment-subtitle):
(button#attachment-save-button):
(div#attachment-save-icon):
* Source/WebCore/rendering/AttachmentLayout.mm:
(WebCore::AttachmentLayout::AttachmentLayout):
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::attachmentIntrinsicSize const):
(WebCore::RenderThemeIOS::paintAttachment):

Canonical link: https://commits.webkit.org/261905@main




More information about the webkit-changes mailing list