[webkit-changes] [WebKit/WebKit] 8b8e7c: Fullscreen window size is incorrect for non-video ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b8e7c2006e19750c16fbb984e54083736cfee08
      https://github.com/WebKit/WebKit/commit/8b8e7c2006e19750c16fbb984e54083736cfee08
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  -----------
  Fullscreen window size is incorrect for non-video elements
https://bugs.webkit.org/show_bug.cgi?id=254166
rdar://102998286

Reviewed by Tim Horton.

254528 at main added logic to adjust the fullscreen window size based on an
element's aspect ratio. However, this should only apply to video elements
(and elements containing a video element), as the aspect ratio of other
elements can be unsuitable for the fullscreen window size.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):

Fallback to a default when the size is zero. Move some logic that is only
necessary when the size is non-zero.

* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):

Pass in a zero size for non-video elements.

Canonical link: https://commits.webkit.org/261904@main