[webkit-changes] [WebKit/WebKit] f6ed34: [WebGPU] copyTextureToTexture does not work with c...

mwyrzykowski noreply at github.com
Mon Mar 20 10:29:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6ed3474524d1341c873608922814812d0b5fcda
      https://github.com/WebKit/WebKit/commit/f6ed3474524d1341c873608922814812d0b5fcda
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  -----------
  [WebGPU] copyTextureToTexture does not work with compressed formats
https://bugs.webkit.org/show_bug.cgi?id=254103
<radar://106887775>

Reviewed by Tadeu Zagallo.

Texture::isValidImageCopySource / isValidImageCopyDestination are only supposed
to be called on depth or stencil formats. They do not return expected values
except for depth formats.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::validateWriteTexture):
Only validate if this is a depth format.

* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::isValidDepthStencilCopySource):
(WebGPU::Texture::isValidDepthStencilCopyDestination):
Assert this is a depth or stencil format.

Canonical link: https://commits.webkit.org/261880@main




More information about the webkit-changes mailing list