[webkit-changes] [WebKit/WebKit] 065785: [WebGPU] GPU process will terminate if RenderPassE...

mwyrzykowski noreply at github.com
Mon Mar 20 10:21:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0657852c61c17f3363de50365c38915ce45c29db
      https://github.com/WebKit/WebKit/commit/0657852c61c17f3363de50365c38915ce45c29db
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] GPU process will terminate if RenderPassEncoder is destructed before endEncoding is called
https://bugs.webkit.org/show_bug.cgi?id=254125
<radar://106906087>

Reviewed by Tadeu Zagallo.

Metal will runtime assert in debug or release if endEncoding
is not called and the encoder goes out of scope.

* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::~ComputePassEncoder):
(WebGPU::ComputePassEncoder::endPass):

* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::~RenderPassEncoder):
Call unconditionally because we set it to nil in the other
location endEncoding is called.

Canonical link: https://commits.webkit.org/261879@main




More information about the webkit-changes mailing list