[webkit-changes] [WebKit/WebKit] 9bcf8f: Web Inspector should not show "Role: foo" for acce...

Tyler Wilcock noreply at github.com
Wed Mar 15 23:57:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9bcf8f6a0c9eb3db3df41e6205acec7ddc13c7ae
      https://github.com/WebKit/WebKit/commit/9bcf8f6a0c9eb3db3df41e6205acec7ddc13c7ae
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Source/WebCore/inspector/InspectorOverlay.cpp

  Log Message:
  -----------
  Web Inspector should not show "Role: foo" for accessibility-is-ignored elements in the hover tooltip
https://bugs.webkit.org/show_bug.cgi?id=253982
rdar://106771408

Reviewed by Patrick Angle.

The advantage of this change is that web developers can now see at a glance whether each element is relevant to accessibility
(and only then see what computed role). If they want more details, they can see them in the Accessibility panel. This better
matches how Chrome and Firefox model their accessibility devtools, and seems generally more useful than status quo.

This change is further motivated by the fact that WebKit will soon implement support for the generic ARIA role, which div
and span implicitly map to. Without the change in this patch, the hover tooltip for every single div and span will show "Role: generic",
which seems very noisy.

* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawElementTitle):

Canonical link: https://commits.webkit.org/261736@main




More information about the webkit-changes mailing list