[webkit-changes] [WebKit/WebKit] cdf472: Fix ASSERTION FAILED: lastDocument->fullscreenMana...

Chirag Shah noreply at github.com
Wed Mar 15 22:51:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdf4725166dd5bc60b6bb881455e1f43094dc031
      https://github.com/WebKit/WebKit/commit/cdf4725166dd5bc60b6bb881455e1f43094dc031
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    A LayoutTests/fullscreen/webkit-exit-full-screen-crash-expected.txt
    A LayoutTests/fullscreen/webkit-exit-full-screen-crash.html
    M Source/WebCore/dom/DocumentFullscreen.cpp

  Log Message:
  -----------
  Fix ASSERTION FAILED: lastDocument->fullscreenManager().fullscreenElement()
https://bugs.webkit.org/show_bug.cgi?id=253987
rdar://106776257

Reviewed by Tim Nguyen.

We don't handle document not being a fullScreenElement in
webkitExitFullscreen which causes a crash on debug builds. This change
fixes that.

* LayoutTests/fullscreen/webkit-exit-full-screen-crash-expected.txt: Added.
* LayoutTests/fullscreen/webkit-exit-full-screen-crash.html: Added.
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::webkitExitFullscreen):

Canonical link: https://commits.webkit.org/261735@main




More information about the webkit-changes mailing list