[webkit-changes] [WebKit/WebKit] 758056: [GStreamer][WebRTC] Improve DataChannel logs

Philippe Normand noreply at github.com
Wed Mar 15 05:20:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 758056c72f5c38f86397703d87f764069d876e55
      https://github.com/WebKit/WebKit/commit/758056c72f5c38f86397703d87f764069d876e55
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.h

  Log Message:
  -----------
  [GStreamer][WebRTC] Improve DataChannel logs
https://bugs.webkit.org/show_bug.cgi?id=253954

Reviewed by Xabier Rodriguez-Calvar.

The logs now mention one unique identifier per data-channel. This works only when building against
GStreamer 1.22 though because it requires new macros.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.cpp:
(WebCore::GStreamerDataChannelHandler::GStreamerDataChannelHandler):
(WebCore::GStreamerDataChannelHandler::~GStreamerDataChannelHandler):
(WebCore::GStreamerDataChannelHandler::setClient):
(WebCore::GStreamerDataChannelHandler::sendStringData):
(WebCore::GStreamerDataChannelHandler::sendRawData):
(WebCore::GStreamerDataChannelHandler::close):
(WebCore::GStreamerDataChannelHandler::checkState):
(WebCore::GStreamerDataChannelHandler::bufferedAmountChanged):
(WebCore::GStreamerDataChannelHandler::onMessageData):
(WebCore::GStreamerDataChannelHandler::onMessageString):
(WebCore::GStreamerDataChannelHandler::onError):
(WebCore::GStreamerDataChannelHandler::onClose):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.h:

Canonical link: https://commits.webkit.org/261683@main




More information about the webkit-changes mailing list