[webkit-changes] [WebKit/WebKit] 41d9bb: WebGLRenderingContextBase has multiple style rule ...
Kimmo Kinnunen
noreply at github.com
Wed Mar 15 05:11:34 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 41d9bbf278b5650c4e6d44ac8060b228f99cd07f
https://github.com/WebKit/WebKit/commit/41d9bbf278b5650c4e6d44ac8060b228f99cd07f
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date: 2023-03-15 (Wed, 15 Mar 2023)
Changed paths:
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Log Message:
-----------
WebGLRenderingContextBase has multiple style rule violations in translation unit local code
https://bugs.webkit.org/show_bug.cgi?id=253949
rdar://problem/106744347
Reviewed by Antti Koivisto.
Fix the issues by:
- use static for functions instead of anonymous namespace
- use std::clamp instead of custom function
- make global variables start with lower-case letter
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::texImageSourceSize):
(WebCore::validateCharacter):
(WebCore::isPrefixReserved):
(WebCore::ScopedUnpackParametersResetRestore::ScopedUnpackParametersResetRestore):
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::reshape):
(WebCore::WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes):
(WebCore::WebGLRenderingContextBase::validateTexImageSourceFormatAndType):
(WebCore::WebGLRenderingContextBase::clampedCanvasSize):
Canonical link: https://commits.webkit.org/261682@main
More information about the webkit-changes
mailing list