[webkit-changes] [WebKit/WebKit] f013f2: Ignore calc() values on colgroup elements

Ahmad Saleem noreply at github.com
Tue Mar 14 03:29:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f013f2c88a3b61a7935de1c53bff8ba598f5fcbc
      https://github.com/WebKit/WebKit/commit/f013f2c88a3b61a7935de1c53bff8ba598f5fcbc
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    A LayoutTests/fast/table/calculated-width-on-col-within-colgroup-expected.txt
    A LayoutTests/fast/table/calculated-width-on-col-within-colgroup.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/auto-layout-calc-width-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/auto-layout-calc-width-001.html
    M Source/WebCore/rendering/AutoTableLayout.cpp

  Log Message:
  -----------
  Ignore calc() values on colgroup elements

https://bugs.webkit.org/show_bug.cgi?id=253841

Reviewed by Alan Baradlay.

This patch aligns WebKit to Blink / Chromium and Gecko / Firefox.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=193912

This patch add condition to ignore calc() values on 'colgroup' elements to align with
web-spec and it progresses WPT test case as well.

* Source/WebCore/rendering/AutoTableLayout.cpp:
(AutoTableLayout::fullRecalc): Add 'isCalculated' condition
* LayoutTests/fast/table/calculated-width-on-col-within-colgroup.html: Add Test Case
* LayoutTests/fast/table/calculated-width-on-col-within-colgroup-expected.txt: Add Test Case Expectation
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/auto-layout-calc-width-001.html: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/auto-layout-calc-width-001-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/261623@main




More information about the webkit-changes mailing list