[webkit-changes] [WebKit/WebKit] acd024: Switch libxslt from soft linking to weak linking

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: acd0241f615226f4fb41d549e2e19103925662ea
      https://github.com/WebKit/WebKit/commit/acd0241f615226f4fb41d549e2e19103925662ea
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/Configurations/WebCore.xcconfig
    M Source/WebCore/PlatformMac.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    R Source/WebCore/xml/SoftLinkLibxslt.cpp
    R Source/WebCore/xml/SoftLinkLibxslt.h
    M Source/WebCore/xml/XSLStyleSheetLibxslt.cpp
    M Source/WebCore/xml/XSLTExtensions.cpp
    M Source/WebCore/xml/XSLTProcessorLibxslt.cpp
    M Source/WebCore/xml/XSLTUnicodeSort.cpp

  Log Message:
  -----------
  Switch libxslt from soft linking to weak linking
https://bugs.webkit.org/show_bug.cgi?id=253827
<rdar://106642393>

Reviewed by Alex Christensen.

On Apple platforms, get rid of libxslt soft linking to use weak
linking instead.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Configurations/WebCore.xcconfig:
- Add "-weak-lxslt" to linker flags.

* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Remove SoftLinkLibxslt.{cpp,h} from the build.

* Source/WebCore/xml/SoftLinkLibxslt.cpp: Remove.
* Source/WebCore/xml/SoftLinkLibxslt.h: Remove.

* Source/WebCore/xml/XSLStyleSheetLibxslt.cpp:
* Source/WebCore/xml/XSLTExtensions.cpp:
* Source/WebCore/xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::transformToString):
* Source/WebCore/xml/XSLTUnicodeSort.cpp:
(xsltTransformErrorTrampoline): Delete.
- Stop including SoftLinkLibxslt.h and remove code needed for
  soft linking.

Canonical link: https://commits.webkit.org/261622@main