[webkit-changes] [WebKit/WebKit] 46fa17: Small build time improvement for WebPreferences

Commit Queue noreply at github.com
Fri Mar 10 09:11:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46fa174c8e6d3d2919ba7c291bc9d2027bf318ae
      https://github.com/WebKit/WebKit/commit/46fa174c8e6d3d2919ba7c291bc9d2027bf318ae
  Author: Brent Fulgham <bfulgham at webkit.org>
  Date:   2023-03-10 (Fri, 10 Mar 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
    M Source/WebKit/Shared/WebPreferencesDefaultValues.h

  Log Message:
  -----------
  Small build time improvement for WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=253681
<rdar://problem/106527449>

Reviewed by Elliott Williams.

WebPreferences.h currently includes <WebCore/LibWebRTCProvider.h>, which is costly to parse.

By adding a small helper function to WebPreferencesDefaultValues, we can avoid requiring users
of WebPreferences.h from including this header. This saves about 9 seconds of parsing time
on an M1 Pro.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultPeerConnectionEnabledAvailable): Added.
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:

Canonical link: https://commits.webkit.org/261502@main




More information about the webkit-changes mailing list