[webkit-changes] [WebKit/WebKit] d71077: REGRESSION (260575 at main): [ iOS ] media/video-elem...

Jer Noble noreply at github.com
Fri Mar 10 08:40:29 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7107716d18192289e1402e9ffdd21fc3634ffc3
      https://github.com/WebKit/WebKit/commit/d7107716d18192289e1402e9ffdd21fc3634ffc3
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-03-10 (Fri, 10 Mar 2023)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  REGRESSION (260575 at main): [ iOS ] media/video-element-fullscreen-not-in-dom-accelerated-iphone.html is a constant failure.
https://bugs.webkit.org/show_bug.cgi?id=252837
rdar://105838163

Reviewed by Ryosuke Niwa.

When we did the "don't host layers from the WebContent process" work, we no longer create a separate
fullscreen video layer and give that layer to the HTMLMediaElement (because we don't create _any_
layers in the WebContent process). So the existing check for a m_videoFullscreenLayer as a proxy of
whether we're in picture-in-picture or fullscreen mode stopped working.

Just replace the layer check with an explicit check of the fullscreen mode.

* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):

Canonical link: https://commits.webkit.org/261501@main




More information about the webkit-changes mailing list