[webkit-changes] [WebKit/WebKit] 89dc20: Fix signpost persistence defaults

bnham noreply at github.com
Thu Mar 9 22:04:29 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89dc203c77903942cb0be03c08ffbb56cc383d1e
      https://github.com/WebKit/WebKit/commit/89dc203c77903942cb0be03c08ffbb56cc383d1e
  Author: Ben Nham <nham at apple.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M Source/WebKit/Resources/Signposts/LoggingPreferences.plist

  Log Message:
  -----------
  Fix signpost persistence defaults
https://bugs.webkit.org/show_bug.cgi?id=253604
rdar://problem/106452342

Reviewed by Geoffrey Garen and Ryosuke Niwa.

In 253387 at main I enabled signposts when tracing tools are running and also tried to make signpost
persistence enabled by default. However the signpost persistence default wasn't correct since the
plist I committed mapped `Signpost-Persisted` to the integer value `1`. It turns out that libtrace
expects `Signpost-Persisted` to be a boolean value, so signpost persistence wasn't actually
enabled by default.

Fix this by making the value a bool instead.

* Source/WebKit/Resources/Signposts/LoggingPreferences.plist:

Canonical link: https://commits.webkit.org/261488@main




More information about the webkit-changes mailing list