[webkit-changes] [WebKit/WebKit] 2ce712: [git-webkit] Handle interupts while pushing

Jonathan Bedard noreply at github.com
Thu Mar 9 21:23:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ce712d5507689221c0f5f2e2ed918cafc093f0a
      https://github.com/WebKit/WebKit/commit/2ce712d5507689221c0f5f2e2ed918cafc093f0a
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M Tools/Scripts/libraries/webkitcorepy/setup.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/terminal_unittest.py
    M Tools/Scripts/libraries/webkitscmpy/setup.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py

  Log Message:
  -----------
  [git-webkit] Handle interupts while pushing
https://bugs.webkit.org/show_bug.cgi?id=253327
rdar://106201813

Reviewed by Elliott Williams.

We should gracefully handle keyboard interupts when running push commands,
since that is a common (and expected) place for engineers to interupt git-webkit.

* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
(Terminal.disable_keyboard_interrupt_stacktracktrace): Disable KeyboardInterupt stacktraces based on logging level.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/terminal_unittest.py:
(TerminalTests.test_interrupt_decorator):
* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py: Disable KeyboardInterupt stacktraces
at the default logging level.

Canonical link: https://commits.webkit.org/261487@main




More information about the webkit-changes mailing list