[webkit-changes] [WebKit/WebKit] b794ba: [WebGPU] createRender/ComputePipelineAsync are uni...

mwyrzykowski noreply at github.com
Thu Mar 9 01:00:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b794bac15380eef65e9a4535759ecf8e9c208b70
      https://github.com/WebKit/WebKit/commit/b794bac15380eef65e9a4535759ecf8e9c208b70
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
    A Source/WebCore/Modules/WebGPU/GPUPipelineError.cpp
    A Source/WebCore/Modules/WebGPU/GPUPipelineError.h
    A Source/WebCore/Modules/WebGPU/GPUPipelineError.idl
    A Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.h
    A Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.idl
    A Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.h
    A Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.idl
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp
    M Source/WebCore/Modules/streams/WritableStream.cpp
    M Source/WebCore/Modules/streams/WritableStream.h
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h
    M Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUDevice.h
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
    M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h

  Log Message:
  -----------
  [WebGPU] createRender/ComputePipelineAsync are unimplemented
https://bugs.webkit.org/show_bug.cgi?id=253404
<radar://106244188>

Reviewed by Myles C. Maxfield.

Add GPUPipelineError and use it to implement createRenderPipelineAsync
and createComputePipelineAsync.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
Add files.

* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::createComputePipelineAsync):
(WebCore::GPUDevice::createRenderPipelineAsync):
Reject the promise on failure as specified in the specification.

* Source/WebCore/Modules/WebGPU/GPUPipelineError.cpp: Added.
(WebCore::GPUPipelineError::GPUPipelineError):
* Source/WebCore/Modules/WebGPU/GPUPipelineError.h: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineError.idl: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.h: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorInit.idl: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.h: Added.
* Source/WebCore/Modules/WebGPU/GPUPipelineErrorReason.idl: Added.
New files.

* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:
Unified build fix.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
(PAL::WebGPU::DeviceImpl::createComputePipelineAsync):
(PAL::WebGPU::DeviceImpl::createRenderPipelineAsync):
Return nullptr on failure.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h:
* Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUDevice.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
New files.

* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
New IDLInterface type.

* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipelineAsync):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipelineAsync):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::createComputePipelineAsync):
(WebKit::RemoteDevice::createRenderPipelineAsync):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::createComputePipelineAsync):
(WebKit::WebGPU::RemoteDeviceProxy::createRenderPipelineAsync):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
Return false or nullptr on failure from the callback.

* Source/WebCore/Modules/streams/WritableStream.cpp:
(WebCore::WritableStream::lock):
(WebCore::WritableStream::locked const):
(WebCore::WritableStream::internalWritableStream):
* Source/WebCore/Modules/streams/WritableStream.h:
(WebCore::WritableStream::lock): Deleted.
(WebCore::WritableStream::locked const): Deleted.
(WebCore::WritableStream::internalWritableStream): Deleted.
Unified build fixes.

Canonical link: https://commits.webkit.org/261415@main




More information about the webkit-changes mailing list