[webkit-changes] [WebKit/WebKit] 89829a: A page with one document doing capture and another...

youennf noreply at github.com
Thu Mar 9 00:52:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89829aa9cfdd0495e87941850dbf64e66a51a1fd
      https://github.com/WebKit/WebKit/commit/89829aa9cfdd0495e87941850dbf64e66a51a1fd
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M Source/WebCore/html/MediaElementSession.cpp
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/webrtc-remote-iframe.html
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/webrtc-remote.html

  Log Message:
  -----------
  A page with one document doing capture and another playing will not handle correctly remote commands
https://bugs.webkit.org/show_bug.cgi?id=253559
rdar://104571980

Reviewed by Eric Carlson.

We are processing the pause/play remote commands as mute/unmute capture in case document is capturing and playing several media streams.
Some video conference websites do capture in one document and play media streams in another document.
Handle this by changing the heuristic to check whether page is capturing instead of the document.

Covered by updated API test.

* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::isDocumentPlayingSeveralMediaStreams):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/webrtc-remote-iframe.html: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/webrtc-remote.html:

Canonical link: https://commits.webkit.org/261414@main




More information about the webkit-changes mailing list