[webkit-changes] [WebKit/WebKit] 3558eb: [popover] Implement popover focusing steps

Tim Nguyen noreply at github.com
Wed Mar 8 21:15:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3558eb52e9aca998f3b1319d3f53dfe1ce40c931
      https://github.com/WebKit/WebKit/commit/3558eb52e9aca998f3b1319d3f53dfe1ce40c931
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-child-dialog-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html
    M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Implement popover focusing steps
https://bugs.webkit.org/show_bug.cgi?id=253231
rdar://106132025

Reviewed by Ryosuke Niwa.

https://html.spec.whatwg.org/#popover-focusing-steps

PR open here to update the popover focusing steps: https://github.com/whatwg/html/pull/8998

The remaining failures are due to new dialog focusing steps being not implemented yet (TBD in https://bugs.webkit.org/show_bug.cgi?id=250795)

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-child-dialog-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt:
* Source/WebCore/dom/Element.cpp:
(WebCore::autoFocusDelegate):
(WebCore::Element::findFocusDelegateForTarget):
(WebCore::Element::findAutofocusDelegate):
* Source/WebCore/dom/Element.h:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::runPopoverFocusingSteps):
(WebCore::HTMLElement::showPopover):

Canonical link: https://commits.webkit.org/261400@main




More information about the webkit-changes mailing list