[webkit-changes] [WebKit/WebKit] 1c291a: _removeDataStoreWithIdentifier should fail when th...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c291a95fe759ba4fa23b4ce7a50698b5ade2e0f
      https://github.com/WebKit/WebKit/commit/1c291a95fe759ba4fa23b4ce7a50698b5ade2e0f
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm

  Log Message:
  -----------
  _removeDataStoreWithIdentifier should fail when the data store is being used by web page
https://bugs.webkit.org/show_bug.cgi?id=253555
rdar://106407998

Reviewed by Chris Dumez.

To avoid undefined behaviors and unexpected results, we don't allow data store to be removed while it is being used by
web page.

API Test: WKWebsiteDataStore.RemoveDataStoreWithIdentifierErrorWhenInUse

* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::removeDataStoreWithIdentifier):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::existingDataStoreForIdentifier):
(WebKit::WebsiteDataStore::hasActivePages):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261399@main