[webkit-changes] [WebKit/WebKit] d0f3ad: [WGSL] Re-land 260735 at main
Tadeu Zagallo
noreply at github.com
Fri Mar 3 01:35:22 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d0f3ad6e6dfcdcec2d4be7019e8b612f30f528a8
https://github.com/WebKit/WebKit/commit/d0f3ad6e6dfcdcec2d4be7019e8b612f30f528a8
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/TypeCheck.h
M Source/WebGPU/WGSL/TypeDeclarations.rb
M Source/WebGPU/WGSL/WGSL.cpp
Log Message:
-----------
[WGSL] Re-land 260735 at main
https://bugs.webkit.org/show_bug.cgi?id=253144
rdar://106078179
Reviewed by Myles C. Maxfield.
The commit had to reverted together with 260433 at main because of build issues with
the JavaScript DSL, so now we re-land it on top of the ruby DSL.
About the actual change (from the original PR):
At first, since there was very little of the type checking implemented, it was
only run right before generating code, errors were only printed and guarded by
a compiler-time flag. While the type checker is still far from complete, it can
now correctly check the examples we've been using for development, so we can move
it into the validation phase.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::check):
(WGSL::typeCheck):
* Source/WebGPU/WGSL/TypeCheck.h:
* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::staticCheck):
(WGSL::prepareImpl):
Canonical link: https://commits.webkit.org/261127@main
More information about the webkit-changes
mailing list