[webkit-changes] [WebKit/WebKit] c1109b: [GTK] Remove the fallback code when GTK fails to c...

Carlos Garcia Campos noreply at github.com
Fri Mar 3 01:31:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1109bfc0991d9d552025256e5744fb3bff89492
      https://github.com/WebKit/WebKit/commit/c1109bfc0991d9d552025256e5744fb3bff89492
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStore.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.h
    M Source/cmake/OptionsGTK.cmake

  Log Message:
  -----------
  [GTK] Remove the fallback code when GTK fails to create the GL context under wayland
https://bugs.webkit.org/show_bug.cgi?id=253233

Reviewed by Adrian Perez de Castro.

If GTK can't do hardware acceleration (which is quite unlikely) it's
better to to just disable acceleration in Webkit too, instead of using
the glReadPixels fallback solution that is slow and mostly untested.

* Source/WebKit/UIProcess/gtk/AcceleratedBackingStore.cpp:
(WebKit::gtkCanUseHardwareAcceleration):
(WebKit::AcceleratedBackingStore::checkRequirements):
* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::AcceleratedBackingStoreWayland::unrealize):
(WebKit::AcceleratedBackingStoreWayland::ensureGLContext):
(WebKit::AcceleratedBackingStoreWayland::makeContextCurrent):
(WebKit::AcceleratedBackingStoreWayland::snapshot):
(WebKit::AcceleratedBackingStoreWayland::paint):
(WebKit::AcceleratedBackingStoreWayland::tryEnsureGLContext): Deleted.
(WebKit::AcceleratedBackingStoreWayland::downloadTexture): Deleted.
* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.h:
* Source/cmake/OptionsGTK.cmake:

Canonical link: https://commits.webkit.org/261126@main




More information about the webkit-changes mailing list