[webkit-changes] [WebKit/WebKit] 76fca0: [browserperfdash-benchmark] Support configuring a ...

Carlos Alberto Lopez Perez noreply at github.com
Wed Mar 1 04:00:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76fca0c6015a36a03d7318b949f9db4bec57a414
      https://github.com/WebKit/WebKit/commit/76fca0c6015a36a03d7318b949f9db4bec57a414
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M Tools/CISupport/build-webkit-org/steps.py
    M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
    M Tools/Scripts/webkitpy/browserperfdash/config-file-example.txt

  Log Message:
  -----------
  [browserperfdash-benchmark] Support configuring a specific set of plans and default config values on the config file
https://bugs.webkit.org/show_bug.cgi?id=252134

Reviewed by Carlos Garcia Campos.

Implement support for allowing to define on the config file a subset of plans
that will be run and default values for the configuration options.

This is useful to define different configurations per bot without having to
use different command line arguments per bot when executing the buildbot step.

The values passed via command line arguments have precedence, so the values
defined on the config file are used only as default values.

* Tools/CISupport/build-webkit-org/steps.py:
(RunBenchmarkTests):
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
(parse_args):
(BrowserPerfDashRunner._parse_config_file):
(BrowserPerfDashRunner):
(BrowserPerfDashRunner._get_test_version_string):
(BrowserPerfDashRunner._upload_result):
(BrowserPerfDashRunner.run):
* Tools/Scripts/webkitpy/browserperfdash/config-file-example.txt:

Canonical link: https://commits.webkit.org/260997@main




More information about the webkit-changes mailing list