[webkit-changes] [WebKit/WebKit] d6668d: [GStreamer][1.22] webrtc/receiver-track-should-sta...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6668df3100e97dcc6d36e0aff664b1a0ae67225
      https://github.com/WebKit/WebKit/commit/d6668df3100e97dcc6d36e0aff664b1a0ae67225
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp

  Log Message:
  -----------
  [GStreamer][1.22] webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html crashing
https://bugs.webkit.org/show_bug.cgi?id=251146

Reviewed by Xabier Rodriguez-Calvar.

The crash was due to webrtcbin detecting an invalid SDP message, containing 2 RTP direction
attributes instead of one. So we now remove attributes unrelated with codec preferences, potentially
leading to internal webrtcbin confusions such as duplicated RTP direction attributes for instance.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp:
(WebCore::GStreamerRtpTransceiverBackend::setDirection):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:
(WebCore::capsFromSDPMedia):

Canonical link: https://commits.webkit.org/260996@main