[webkit-changes] [WebKit/WebKit] 0a2e45: REGRESSION(264918 at main): GB18030 encoding isn't ho...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a2e4563bda07006e0ca65e395f90ce20a615afe
      https://github.com/WebKit/WebKit/commit/0a2e4563bda07006e0ca65e395f90ce20a615afe
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-06-29 (Thu, 29 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.any.js
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder.html
    M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp

  Log Message:
  -----------
  REGRESSION(264918 at main): GB18030 encoding isn't hooked up correctly
https://bugs.webkit.org/show_bug.cgi?id=258251
rdar://110952885

Reviewed by Myles C. Maxfield.

The 2022 changes to GB-180030 make 36 code points' encoding and decoding asymmetric, so we can't use the the same index lookup for both directions.
I add and update tests for encoding and decoding all 36 code points.

* LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.any.js:
* LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder.html:
* Source/WebCore/PAL/pal/text/TextCodecCJK.cpp:
(PAL::gb18030AsymmetricEncode):
(PAL::gbEncodeShared):

Canonical link: https://commits.webkit.org/265633@main