[webkit-changes] [WebKit/WebKit] 6f4718: Fix page load hang due to empty srcObject on HTMLM...

Chirag Shah noreply at github.com
Wed Jun 28 16:29:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f4718092396a1be34874dd06cd69dc0db43ccca
      https://github.com/WebKit/WebKit/commit/6f4718092396a1be34874dd06cd69dc0db43ccca
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    A LayoutTests/media/media-src-empty-page-load-hang-expected.txt
    A LayoutTests/media/media-src-empty-page-load-hang.html
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  Fix page load hang due to empty srcObject on HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=258633
rdar://111155451

Reviewed by Eric Carlson.

This change fixes the page load which never finishes when the source
object is an empty blob. This happened because we don't treat it the
same as we do the source attribute, which results in the noneSupported()
error handler from not being called.

* LayoutTests/media/media-src-empty-page-load-hang-expected.txt: Added.
* LayoutTests/media/media-src-empty-page-load-hang.html: Added.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectMediaResource):

Canonical link: https://commits.webkit.org/265601@main




More information about the webkit-changes mailing list