[webkit-changes] [WebKit/WebKit] de109a: Crash under WebAuthenticatorCoordinatorProxy::isUs...

Chris Dumez noreply at github.com
Wed Jun 28 16:20:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de109a5e758078e060160438c6049a92caafe237
      https://github.com/WebKit/WebKit/commit/de109a5e758078e060160438c6049a92caafe237
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

  Log Message:
  -----------
  Crash under WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable(WebCore::SecurityOriginData const&, WTF::CompletionHandler<void (bool)>&&)
https://bugs.webkit.org/show_bug.cgi?id=258646
rdar://110384303

Reviewed by J Pascoe.

Add missing early return in this function. Otherwise, we may end up calling
the handler CompletionHandler twice and we'll crash the second time. This
is because CompletionHandler null themselves out when they get called, since
they're meant to only be called once.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

Canonical link: https://commits.webkit.org/265600@main




More information about the webkit-changes mailing list