[webkit-changes] [WebKit/WebKit] fe4a83: [CSS Container Queries] Container units in contain...

Antti Koivisto noreply at github.com
Wed Jun 28 09:19:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe4a838ddc27d979c45b3db9e7418285a3c9bdde
      https://github.com/WebKit/WebKit/commit/fe4a838ddc27d979c45b3db9e7418285a3c9bdde
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-dynamic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-fallback-expected.txt
    M Source/WebCore/style/ContainerQueryEvaluator.cpp

  Log Message:
  -----------
  [CSS Container Queries] Container units in container query should evaluate against ancestor container
https://bugs.webkit.org/show_bug.cgi?id=258617
rdar://111446508

Reviewed by Tim Nguyen.

Currently they are always resolved against the small viewport size.

https://drafts.csswg.org/css-contain-3/#container-lengths

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-dynamic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-fallback-expected.txt:
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::featureEvaluationContextForQuery const):

Pass the container itself to CSSToLengthConversionData as the element for container unit resolution.

Canonical link: https://commits.webkit.org/265583@main




More information about the webkit-changes mailing list