[webkit-changes] [WebKit/WebKit] 16e3d6: REGRESSION (260897 at main): Occasional crash when ri...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16e3d68d600a2b0236681d13820e9ec5d33b9901
      https://github.com/WebKit/WebKit/commit/16e3d68d600a2b0236681d13820e9ec5d33b9901
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebContextMenuProxy.cpp
    M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm

  Log Message:
  -----------
  REGRESSION (260897 at main): Occasional crash when right clicking an image
https://bugs.webkit.org/show_bug.cgi?id=258599
rdar://110708014

Reviewed by Wenson Hsieh.

260897 at main introduced additional asynchronicity when generating context menu
information, to perform QR code detection. Consequently, it is possible for
the `WebPageProxy` to be destroyed prior to finishing detection. Add a
null-check for `WebContextMenuProxy::page` to avoid crashes in this scenario.

* Source/WebKit/UIProcess/WebContextMenuProxy.cpp:
(WebKit::WebContextMenuProxy::show):
* Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/265582@main