[webkit-changes] [WebKit/WebKit] 305089: [GStreamer][MediaStream] Deadlock between capture ...

Philippe Normand noreply at github.com
Mon Jun 26 01:19:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30508986e68cdd3dbfee27c0ddeef373e5edff4c
      https://github.com/WebKit/WebKit/commit/30508986e68cdd3dbfee27c0ddeef373e5edff4c
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  -----------
  [GStreamer][MediaStream] Deadlock between capture source and mediastreamsrc element on WebProcess main thread
https://bugs.webkit.org/show_bug.cgi?id=258349

Reviewed by Xabier Rodriguez-Calvar.

The mediastream src element now emits a single non-empty stream collection when associating with its
MediaStream tracks. Doing so while in the process of pushing buffers downstream was triggering a
deadlock with the capturer pipeline.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(WebKitMediaStreamObserver::activeStatusChanged):
(WebKitMediaStreamObserver::didRemoveTrack):
(webkitMediaStreamSrcChain):
(webkitMediaStreamSrcPostStreamCollection):
(webkitMediaStreamSrcEnsureStreamCollectionPosted):
(webkitMediaStreamSrcSetStream):

Canonical link: https://commits.webkit.org/265507@main




More information about the webkit-changes mailing list