[webkit-changes] [WebKit/WebKit] 7cc365: [LFC] Cleanup full LFC codepath

Alan Baradlay noreply at github.com
Sun Jun 25 21:14:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7cc365707c03970445cec23ec9a2c2be6a80eedd
      https://github.com/WebKit/WebKit/commit/7cc365707c03970445cec23ec9a2c2be6a80eedd
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-06-25 (Sun, 25 Jun 2023)

  Changed paths:
    M Source/WebCore/layout/FormattingState.h
    M Source/WebCore/layout/formattingContexts/FormattingContext.h
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [LFC] Cleanup full LFC codepath
https://bugs.webkit.org/show_bug.cgi?id=258493

Reviewed by Antti Koivisto.

1. Full LFC codepath has not been functional for a while now.
2. Integration codepath has become the preferred flow to layout content.

* Source/WebCore/layout/FormattingState.h:
* Source/WebCore/layout/formattingContexts/FormattingContext.h:
(WebCore::Layout::FormattingContext::layoutInFlowContent):
(WebCore::Layout::FormattingContext::usedContentHeight const):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layout):
(WebCore::Layout::FlexFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContent): Deleted.
(WebCore::Layout::FlexFormattingContext::usedContentHeight const): Deleted.
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::computeIntrinsicWidthConstraintsForFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration): Deleted.
(WebCore::Layout::FlexFormattingContext::computedIntrinsicWidthConstraintsForIntegration): Deleted.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowAndFloatContent):
(WebCore::Layout::InlineFormattingContext::layoutOutOfFlowContent):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent): Deleted.
(WebCore::Layout::InlineFormattingContext::layoutInFlowAndFloatContentForIntegration): Deleted.
(WebCore::Layout::InlineFormattingContext::layoutOutOfFlowContentForIntegration): Deleted.
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraintsForIntegration): Deleted.
(WebCore::Layout::InlineFormattingContext::usedContentHeight const): Deleted.
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot): Deleted.
(WebCore::Layout::InlineFormattingContext::computeHorizontalMargin): Deleted.
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin): Deleted.
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::adjustMarginStartForListMarker const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustOutsideListMarkersPosition):
(WebCore::Layout::LineBoxBuilder::adjustMarginStartForListMarker const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
(WebCore::Layout::InlineDisplayContentBuilder::formattingContext const):
(WebCore::Layout::InlineDisplayContentBuilder::formattingGeometry const): Deleted.
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::computeIntrinsicWidthConstraints):
(WebCore::LayoutIntegration::FlexLayout::layout):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::computeIntrinsicWidthConstraints):
(WebCore::LayoutIntegration::LineLayout::layout):

Canonical link: https://commits.webkit.org/265506@main




More information about the webkit-changes mailing list