[webkit-changes] [WebKit/WebKit] cda934: REGRESSION (265125 at main): Crash in content process...

Simon Fraser noreply at github.com
Wed Jun 21 17:19:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cda93437a8a8b19eee48d190820313362509af9c
      https://github.com/WebKit/WebKit/commit/cda93437a8a8b19eee48d190820313362509af9c
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-06-21 (Wed, 21 Jun 2023)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.cpp

  Log Message:
  -----------
  REGRESSION (265125 at main): Crash in content process after manually killing the GPU process
https://bugs.webkit.org/show_bug.cgi?id=258330
rdar://110998883

Reviewed by Chris Dumez.

There were a couple of code paths in IPC that could result in Connection::sendSync() returning noError, but also
no replyArguments.

First, m_shouldWaitForSyncReplies is set to `false` if the connection closes, so return error in this case.

Second, in `Connection::sendSyncMessage()`, make sure that we return an error in the case where the returned decoder
is null.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::sendSyncMessage):
(IPC::Connection::waitForSyncReply):

Canonical link: https://commits.webkit.org/265382@main




More information about the webkit-changes mailing list