[webkit-changes] [WebKit/WebKit] eb8b06: Stop squaring GameController haptics intensity val...

Chris Dumez noreply at github.com
Wed Jun 21 17:12:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb8b06f8fc5c12e029469f06b19650760c3ae2f5
      https://github.com/WebKit/WebKit/commit/eb8b06f8fc5c12e029469f06b19650760c3ae2f5
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-06-21 (Wed, 21 Jun 2023)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm

  Log Message:
  -----------
  Stop squaring GameController haptics intensity values on macOS 14+
https://bugs.webkit.org/show_bug.cgi?id=258368
rdar://111120352

Reviewed by Brent Fulgham.

When we implemented Gamepad vibration using GameController, we had to get the
square roots of haptics intensity values before passing them to the framework.

GameController was updated in macOS 14+ (rdar://110338126) so that this is no
longer needed. To maintain the behavior, we now need to pass values as-is to
the framework, without computing their square root first.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/platform/gamepad/cocoa/GameControllerHapticEffect.mm:
(WebCore::magnitudeToIntensity):

Canonical link: https://commits.webkit.org/265381@main




More information about the webkit-changes mailing list