[webkit-changes] [WebKit/WebKit] 64cb5c: XMLHttpRequest.responseXML.characterSet may be ina...

Chris Dumez noreply at github.com
Thu Jun 15 15:08:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 64cb5c7438da9cd5fc4e639fe0a763a87a9b00a9
      https://github.com/WebKit/WebKit/commit/64cb5c7438da9cd5fc4e639fe0a763a87a9b00a9
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-06-15 (Thu, 15 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/charset/xhr-expected.txt
    M Source/WebCore/xml/XMLHttpRequest.cpp

  Log Message:
  -----------
  XMLHttpRequest.responseXML.characterSet may be inaccurate
https://bugs.webkit.org/show_bug.cgi?id=258148

Reviewed by Ryosuke Niwa.

When constructing a document in XMLHttpRequest::responseXML(), we would fail to pass
the TextDecoder we used on the new document (unlike what we do in the HTML parser).
This means that Document::characterSet() would not be able to determine the encoding
our decoder used and would always return UTF-8.

* LayoutTests/imported/w3c/web-platform-tests/html/syntax/charset/xhr-expected.txt:
* Source/WebCore/xml/XMLHttpRequest.cpp:

Canonical link: https://commits.webkit.org/265210@main




More information about the webkit-changes mailing list