[webkit-changes] [WebKit/WebKit] 1ea561: Web Inspector: REGRESSION(264158 at main) Sources tab...

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ea561941b3734c55e84711becbc9d2292166228
      https://github.com/WebKit/WebKit/commit/1ea561941b3734c55e84711becbc9d2292166228
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2023-06-15 (Thu, 15 Jun 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
    M Source/WebInspectorUI/UserInterface/Views/WorkerTreeElement.js

  Log Message:
  -----------
  Web Inspector: REGRESSION(264158 at main) Sources tab never shows files when inspecting JS Context
https://bugs.webkit.org/show_bug.cgi?id=258136
rdar://110119826

Reviewed by Devin Rousso and Patrick Angle.

When inspecting a JSContext, `WI.pageTarget` is null.
A JSContex's target type is `WI.TargetType.JavaScript`.

At this point, the `target.mainResource` is `null`,
tripping assertions and causing a crash later down the call stack
when attempting to render the tree element for the assumed worker script.

Fix this by explicitly checking for the target type of `WI.TargetType.Worker`
before attempting to continue rendering source tree elements for worker targets.

* Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel.prototype._handleResourceGroupingModeChanged):

Canonical link: https://commits.webkit.org/265209@main