[webkit-changes] [WebKit/WebKit] 066cf3: Select with multiple enabled does not consistently...

Ahmad Saleem noreply at github.com
Mon Jun 5 13:52:30 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 066cf30607d538a2f7766f4acf615fb0a9118a4c
      https://github.com/WebKit/WebKit/commit/066cf30607d538a2f7766f4acf615fb0a9118a4c
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-06-05 (Mon, 05 Jun 2023)

  Changed paths:
    A LayoutTests/fast/forms/select/multiselect-in-listbox-mouse-release-outside-expected.txt
    A LayoutTests/fast/forms/select/multiselect-in-listbox-mouse-release-outside.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/page/AutoscrollController.cpp

  Log Message:
  -----------
  Select with multiple enabled does not consistently fire OnChange

https://bugs.webkit.org/show_bug.cgi?id=257565

Reviewed by Ryosuke Niwa.

This patch aligns WebKit with Blink / Chromium and Gecko / Firefox.

Partial Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=164563

This patch adds logic for the case, when the listbox is scrollable to
fire 'onChange' event when the selection is dropped outside of 'listbox'.

* Source/WebCore/page/AutoscrollController.cpp:
(AutoscrollController::startAutoscrollForSelection): As above
* LayoutTests/fast/forms/select/multiselect-in-listbox-mouse-release-outside.html: Add Test Case
* LayoutTests/fast/forms/select/multiselect-in-listbox-mouse-release-outside-expected.txt: Add Test Case Expectation
* LayoutTests/platform/ios/TestExpectations: 'iOS' exception due to lack of 'listbox' appearance

Canonical link: https://commits.webkit.org/264873@main




More information about the webkit-changes mailing list