[webkit-changes] [WebKit/WebKit] e25dc4: [IFC] Remove redundant LineBuilder::computedIntrin...
Alan Baradlay
noreply at github.com
Mon Jun 5 13:32:38 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e25dc4918f8854815e772740d06cca3a0abae82d
https://github.com/WebKit/WebKit/commit/e25dc4918f8854815e772740d06cca3a0abae82d
Author: Alan Baradlay <zalan at apple.com>
Date: 2023-06-05 (Mon, 05 Jun 2023)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
Log Message:
-----------
[IFC] Remove redundant LineBuilder::computedIntrinsicWidth
https://bugs.webkit.org/show_bug.cgi?id=257685
Reviewed by Antti Koivisto.
Since both layoutInlineContent and computedIntrinsicWidth run the same placement logic and
LineBuilder already tracks isInIntrinsicWidthMode, we could just
call LineBuilder::layoutInlineContent in case of preferred width computation and remove this redundant method.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
Canonical link: https://commits.webkit.org/264872@main
More information about the webkit-changes
mailing list