[webkit-changes] [WebKit/WebKit] ad8dd0: Parameters to throw alias with stack elements in W...

Commit Queue noreply at github.com
Mon Jul 31 11:35:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad8dd02f9e83f1b5199e57dfd59f785223da57c5
      https://github.com/WebKit/WebKit/commit/ad8dd02f9e83f1b5199e57dfd59f785223da57c5
  Author: David Degazio <d_degazio at apple.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    A JSTests/wasm/stress/throw-multiple-values.js
    A JSTests/wasm/stress/throw-with-live-value-on-stack.js
    M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp

  Log Message:
  -----------
  Parameters to throw alias with stack elements in WASM LLInt
https://bugs.webkit.org/show_bug.cgi?id=256818
rdar://108036137

Reviewed by Yusuke Suzuki.

Correctly computes stack offsets when materializing the operands of
a wasm_throw instruction in the WasmLLIntGenerator by counting relative
to the stack height before the operands were popped as opposed to after.

* JSTests/wasm/stress/throw-multiple-values.js: Added.
(async test):
* JSTests/wasm/stress/throw-with-live-value-on-stack.js: Added.
(async test):
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::addThrow):

Originally-landed-as: 259548.762 at safari-7615-branch (7fb3ced7874a). rdar://108036137
Canonical link: https://commits.webkit.org/266447@main




More information about the webkit-changes mailing list